New ITS MC Track task - #299
Merged
Merged
Conversation
knopers8
reviewed
Mar 25, 2022
knopers8
reviewed
Mar 25, 2022
knopers8
reviewed
Mar 25, 2022
Contributor
Author
|
Dear @chiarazampolli. @knopers8 I have resolved issues in the new commit. Please, could you review changes? |
Collaborator
IsakovAD
marked this pull request as ready for review
March 28, 2022 11:15
Contributor
Author
|
One note, this PR will not be working without a new PR in QC (AliceO2Group/QualityControl#1115), so maybe we should wait with merging? I have changed the title to [WIP] to avoid merging. |
Collaborator
|
If that is the case, indeed we should not merge it yet. Chiara |
knopers8
approved these changes
Mar 28, 2022
Contributor
|
@chiarazampolli / @knopers8 I enabled auto-merge for the QC PR (tests are almost done... last one running). Please merge this one by noon so that we have the task in the new suite. Thanks a lot! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new ITS MC Track task